Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Address): convert to enum size prop, deprecate boolean #269

Merged
merged 1 commit into from
Jun 24, 2020
Merged

feat(Address): convert to enum size prop, deprecate boolean #269

merged 1 commit into from
Jun 24, 2020

Conversation

ahobson
Copy link
Contributor

@ahobson ahobson commented Jun 19, 2020

Summary

Use size enum prop, deprecate boolean big, medium, and slim props

Related Issues or PRs

@ahobson ahobson force-pushed the adh-address-prop-enum branch from a36891b to be5d62c Compare June 24, 2020 14:54
@ahobson ahobson merged commit 952bb71 into develop Jun 24, 2020
@ahobson ahobson deleted the adh-address-prop-enum branch June 24, 2020 16:37
@haworku haworku mentioned this pull request Jun 29, 2020
Merged
haworku pushed a commit that referenced this pull request Jun 29, 2020
@ahobson @haworku
feat(Address): convert to enum size prop, deprecate boolean (#269)
d0912f0 
* closes #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haworku haworku haworku approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

@tinyels tinyels Awaiting requested review from tinyels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Add size enum prop to Address
2 participants
@ahobson @haworku